Exceptions - Log Deprecations #6703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najdanovicivan
force-pushed
the
execptions-deprecated
branch
from
a1b8793 to
4df2884
Compare
najdanovicivan
force-pushed
the
execptions-deprecated
branch
from
4df2884 to
aaba7c1
Compare
samsonasik
reviewed
Oct 17, 2022
| */ | ||
| public function errorHandler(int $severity, string $message, ?string $file = null, ?int $line = null) | ||
| { | ||
| if ($this->config->failOnDeprecated !== true && $severity === E_DEPRECATED) { |
Member
There was a problem hiding this comment.
isset failOnDeprecated property exist should be applied
Member
|
@najdanovicivan You didn't see my message on Slack? 😅 I also have a working implementation for this. |
5 tasks
Contributor
Author
|
@paulbalandan I see you did much more detailed implementation in #6705. I'm going to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the framework will always throw critical error on deprecation. This adds option to make deprecations only be logged as warnings.
Checklist: