Skip to content

Exceptions - Log Deprecations #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Exceptions - Log Deprecations #6703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/Config/Exceptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,19 @@ class Exceptions extends BaseConfig
*/
public $ignoreCodes = [404];

/**
* --------------------------------------------------------------------------
* DO NOT FAIL ON DEPRECATIONS
* --------------------------------------------------------------------------
* By default deprecation errors will be thrown as exception stopping
* the framework from further code execution. With this parameter set to
* true the deprecations will not throw exception but instead will be written
* to the log with warning level.
*
* @var bool
*/
public $failOnDeprecated = true;

/**
* --------------------------------------------------------------------------
* Error Views Path
Expand Down
14 changes: 14 additions & 0 deletions system/Debug/Exceptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,20 @@ public function exceptionHandler(Throwable $exception)
*/
public function errorHandler(int $severity, string $message, ?string $file = null, ?int $line = null)
{
if ($this->config->failOnDeprecated !== true && $severity === E_DEPRECATED) {
Copy link
Member

@samsonasik samsonasik Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isset failOnDeprecated property exist should be applied

if ($this->config->log === true) {
$exception = new ErrorException($message, 0, $severity, $file, $line);
log_message('warning', "{message}\nin {exFile} on line {exLine}.\n{trace}", [
'message' => $exception->getMessage(),
'exFile' => clean_path($exception->getFile()), // {file} refers to THIS file
'exLine' => $exception->getLine(), // {line} refers to THIS line
'trace' => self::renderBacktrace($exception->getTrace()),
]);
}

return;
}

if (! (error_reporting() & $severity)) {
return;
}
Expand Down