Skip to content

⚡️ Speed up method BoxRESTClientViaToken.create_client by 18% #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method BoxRESTClientViaToken.create_client by 18% #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backend/python/app/sources/client/box/box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,15 @@ class BoxRESTClientViaToken:
"""Box client via Developer Token or OAuth2 access token."""
def __init__(self, access_token: str) -> None:
self.access_token = access_token
self._auth = BoxDeveloperTokenAuth(token=self.access_token)
self.box_client = None

async def create_client(self) -> BoxSDKClient: # type: ignore[valid-type]
"""Create Box client using Developer Token or OAuth2 token."""
auth = BoxDeveloperTokenAuth(token=self.access_token)
self.box_client = BoxSDKClient(auth=auth)
# Reuse initialized auth object for efficiency
# Only re-instantiate client when necessary
if self.box_client is None:
self.box_client = BoxSDKClient(auth=self._auth)
return self.box_client

def get_box_client(self) -> BoxSDKClient: # type: ignore[valid-type]
Expand Down