Skip to content

Refactor/secret object step arguments #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Refactor/secret object step arguments #3322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e36506
Content of Before/After/All hooks will be logged in Allure report now
Jun 21, 2021
31a1995
Merge branch 'codeceptjs:3.x' into 3.x
jancorvus Sep 7, 2021
7e0dc53
Merge branch 'codeceptjs:3.x' into 3.x
jancorvus Sep 17, 2021
22bfc21
Merge branch 'codeceptjs:3.x' into 3.x
jancorvus May 24, 2022
87f0336
refactor(step): if an argument of a step is an object and the object …
jancorvus May 24, 2022
46c5676
refactor(step): Updated the documentation about the usage of secret()…
jancorvus May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/basics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ To fill in sensitive data use the `secret` function, it won't expose actual valu

```js
I.fillField('password', secret('123456'));
// you can also mask a property value in an object as an argument
I.doMyCustomLogIn({ login: 'Jan', password: secret('12345') });
```

### Assertions
Expand Down
6 changes: 5 additions & 1 deletion lib/step.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,11 @@ class Step {
} else if (arg.toString && arg.toString() !== '[object Object]') {
return arg.toString();
} else if (typeof arg === 'object') {
return JSON.stringify(arg);
return JSON.stringify(
Object.fromEntries(
Object.entries(arg).map(([key, value]) => [key, value instanceof Secret ? '*****' : value]),
),
);
}
return arg;
}).join(', ');
Expand Down
6 changes: 3 additions & 3 deletions test/acceptance/codecept.Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ module.exports.config = {
restart: process.env.BROWSER_RESTART || false,
browser: process.env.BROWSER || 'chromium',
ignoreHTTPSErrors: true,
webkit: {
ignoreHTTPSErrors: true,
}
webkit: {
ignoreHTTPSErrors: true,
},
},
JSONResponse: {
requestHelper: 'Playwright',
Expand Down