Skip to content

Conversation

@jancorvus
Copy link
Contributor

Motivation/Description of the PR

  • A step can have objects as arguments. A property value of such an object should be able to be masked with secret().
// besides this usage
I.fillField('password', secret('123456'));
// I want this be possible as well
I.doMyCustomLogIn({ login: 'Jan', password: secret('12345') });

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test) They are failing for me in master

@Arhell Arhell requested review from DavertMik and kobenguyent May 28, 2022 08:13
@DavertMik
Copy link
Contributor

Hi, I don't like the implementation as it is limited and adds searching for secrets to arbitrary objects, which is not entirely efficient.
I will come up with my own implementation. Thank you and sorry for the delay in response!

@DavertMik DavertMik closed this Jul 5, 2022
@DavertMik DavertMik mentioned this pull request Jul 7, 2022
33 tasks
@DavertMik
Copy link
Contributor

@jancorvus Please review my implementation #3355
And check if it matches your needs.
Thanks!

@jancorvus
Copy link
Contributor Author

@DavertMik
🤔 I am getting a TS error while adding the 2nd param to

I.sendData(secret({ bear: 'panda'}, 'bear'));
TS2554: Expected 1 arguments, but got 2.

@kobenguyent kobenguyent mentioned this pull request Jul 13, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants