Skip to content

Creating Box #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Creating Box #481

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d764926
Creating Box
DominicS99 Oct 27, 2024
a018dbc
Style updates to App and Box.
DominicS99 Oct 28, 2024
675c417
Update workspaces/simon-game/src/app/components/App.tsx
DominicS99 Oct 28, 2024
d4b549e
Run with yarn format, and made margin a prop component
DominicS99 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions workspaces/simon-game/src/app/components/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import React from "react";

import { Box } from "./Box.tsx";

export function App() {
return (
<div>
<div
style={{ backgroundColor: "lightblue", height: 100, width: 100 }}
></div>
<div style={{ backgroundColor: "orange", height: 100, width: 100 }}></div>
<div style={{ backgroundColor: "green", height: 100, width: 100 }}></div>
<Box color="red" />
<Box color="#0050B5" /> //cobalt blue
<Box color="green" />
<Box color="yellow" />
</div>
);
}
17 changes: 17 additions & 0 deletions workspaces/simon-game/src/app/components/Box.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from "react";

type Props = { color?: string; height?: number; width?: number };

export function Box(props: Props) {
return (
<div
style={{
backgroundColor: props.color ?? "lightblue",
height: props.height ?? 100,
width: props.width ?? 100,
Comment on lines +15 to +16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but as mentioned in another comment I assume we're not going to vary the box sizes arbitrarily. As such, by making these not props, we can guarantee that every instance of Box is the same size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Saw that you did this for practice -- sounds good for now though I think you'll get plenty of practice regardless!)

borderRadius: 20, // rounded corners
margin: 10, // spaces
}}
/>
);
}
Loading