Creating Box #481
Merged
Creating Box #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miorel
reviewed
Oct 27, 2024
miorel
reviewed
Oct 27, 2024
Box objects will have rounded corners and spaces; added null op; dynamic height and width updated. App now has 4 boxes of different colors
|
New commit with requested changes and some style updates |
miorel
reviewed
Oct 28, 2024
miorel
reviewed
Oct 28, 2024
miorel
reviewed
Oct 28, 2024
Comment on lines
+10
to
+11
| height: props.height ?? 100, | ||
| width: props.width ?? 100, |
There was a problem hiding this comment.
This is fine, but as mentioned in another comment I assume we're not going to vary the box sizes arbitrarily. As such, by making these not props, we can guarantee that every instance of Box is the same size.
There was a problem hiding this comment.
(Saw that you did this for practice -- sounds good for now though I think you'll get plenty of practice regardless!)
miorel
approved these changes
Oct 28, 2024
Co-authored-by: Miorel-Lucian Palii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.