-
Notifications
You must be signed in to change notification settings - Fork 7
Ensemble blog #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble blog #469
Conversation
|
✔️ Deploy Preview for cmu-delphi-main ready! 🔨 Explore the source changes: dac3242 🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/615f3712f9daae00079b867a 😎 Browse the preview: https://deploy-preview-469--cmu-delphi-main.netlify.app |
|
@sgratzl I know you have a lot of stuff on your plate now (all requests from me 🙂?). I wanted to flag this one as being the current priority. It would be ideal to get the blog post very soon. Can you let me know if you need anything else from me? Thank you! |
before install github dependencies
|
took a while but the blog post is built and also the CI builds the blog now successfully again. |
|
@sgratzl Thank you so much! I just checked the blog and it looks great. Preview link it here for everyone's convenience. Couple very small things left to do before we merge (and as soon as we merge does it then go live)?
|
|
@ryantibs anybody can -- just go to https://unsplash.com/ search for any keyword you like and pick a photo. Resolution details for the banner and thumbnail:
if you don't have image software that lets you crop and resize, you send the image to me and I can do it, but it's not hard if you want to learn -- Preview or Pixelmator will do it on mac, or on linux there's a nautilus plugin or GIMP. Try to be ready to release by end of day today if you can, or consider Monday+ as a release date for this post. Friday releases are generally a bad idea, since if something goes wrong it usually means asking people to give up part of their weekend to fix it. The fewer Friday releases we do, the more likely we'll be to have the energy to respond to a weekend emergency when it's really needed. |
|
@krivard I took care of all the remaining items (wrote bios for Nick and Evan bios, hero and thumb images) and fixed the merge conflicts against dev. And, happily all the checks pass now! But there looks to be one thing left to do. Despite the fact that I swapped out the new names of the hero and thumbnail images in the Rmd file, it has not been updated in the preview. @sgratzl Do we need to rebuild the blog post, and if so, can you please do that? Thank you. |
|
Sam did the hard part so I was able to rebuild using the gitpod. Nice choice for the hero image btw 😄 |
|
Thanks! Looks good to me, ready to merge from my end! |
krivard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I believe I've added the biog Rmd in the right format, updated the dependencies (two R packages:
covidDataandcovidHubUtils), and added Nick and Evan to the people index.However I didn't try to build the blog yet. The way I would think to do it (based on what we did back when we had a
delphi-blogrepo) looks nothing as complicated on the blog instructions on the README for this repo.Does anybody want to try to build it for me? 🙂