-
Notifications
You must be signed in to change notification settings - Fork 7
Various website edits #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Change Google.org to be a collaborator. - Add Google is itself a collaborator (survey work and the search trends signals). - Add Quidel and SafeGraph as collaborators.
|
✔️ Deploy Preview for cmu-delphi-main ready! 🔨 Explore the source changes: 7acd2a6 🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/615f126233fc820007cbe890 😎 Browse the preview: https://deploy-preview-454--cmu-delphi-main.netlify.app |
|
@krivard Re my last commit: there appears to no reason to distinguish collaborators and supporters, based on the language we use that precedes the list that gets presented ("We're grateful for financial and other support from our collaborators and supporters:"). If we want to simplify, we can just kill the "group" category in the metadata? (More detail: the current designation of collaborator/supporter, before my commit, seemed highly arbitrary: Google.org is listed as a supporter, but yet they did indeed collaborate with us via the Fellows; and furthermore other entities here purely gave us money, like DTRA, Uptake, etc., and we still call them collaborators.) |
Mostly just tighten text throughout and fix errant links.
A little bit of wordsmithing.
Nobody else has a middle initial.
The CDC's is not even an official logo, it looks amateur-ish, and besides they are being displayed a bit ugly (large and pixelated).
|
@krivard If you look back at 00dff6b, and the subsequent two commits, I tried to remove the CDC and Reich Lab images on the "Center of Excellence" page, but I had to refer those commits because they were causing errors. I would still like to remove these images though (commit message in 00dff6b gives my rationale). Or if we can't remove them, then find nicer (and proper resolution) images. |
|
@krivard Here is something I want to change, but I easily can't figure out how: near the top of the "About" page, our mission statement is pasted in bold, big text. But it's a bit awkward because as a stand-alone sentence it doesn't make grammatical sense ("Develop the theory ..."). I'd like to either put a subheader right above this that says "Our Mission" or, precede this sentence with "Our mission: ...". |
- A variety of copyedits - Update blog item to point to latest post - Update research item to point to latest paper
- Be consistent with use of Title Case (they are titles after all) - Remove Roni's presentation from a while ago (we have many many other more recent presentations and none of them are linked here ... so at the moment it doesn't make sense to link just this one)
- Use Title Caps throughout (to be consistent with other pages on our website) - Make links span only the relevant parts of sentences and not whole sentences.
3e01841 to
48b19e9
Compare
|
Hi @krivard, I made it through the "About" pages and think this is enough for now. You can see I left three comments for you but only the last two have actual action items where I'm asking for help (the first was just explaining what I did and suggesting that we can remove some category from the metadata but not a real action item). Everything on my end is ready-to-go, I'm just missing a hero image for the indicators paper on the carousel. It currently has the hero image from Logan's thesis (old publication item on the carousel). I opened #464 for help on that. (But I think we can live with the old hero image for now and I wouldn't wait for that to be resolved before merging the PR if that takes a while. We can always fix that later.) |
|
@ryantibs On removing the images: the coe:index.md file gets parsed by the coe:sisters partial layout. You can drop the image from the layout file so long as nothing else that uses that layout needs an image, then drop the |
|
@ryantibs On the mission statement on the About page: It looks like that's from calling the constant |
- Reverse chronological order - Add some links and a bit more structure.
|
Thanks @krivard that was helpful. I've finished all my changes and everything is good to go content wise. One last thing: the spacing looks awkward on sub-bullets the about page. Screenshot below There is a big whitespace between the first-level and second-level bullets, but then no whitespace between the next first-level bullet. So "March 2020" is right up against the previous bullet, as is "2019". I think this must be a result of our style layers, because the GitHub markdown preview looks normal to me. @sgratzl Can you take a look? |
|
@ryantibs @krivard Something just caught my eye in the very last bullet:
I don't think we can say that we deployed this system TO CDC or to states' depts of health, because they didn't install anything and we have no evidence how much they use it. Rather, I think we could say we deployed these systems FOR CDC, states' depts of health, and the public. |
|
|
Perfect, thanks Sam. @krivard: We are good to go from my end. |
krivard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions to resolve before merging
krivard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀


This is a work in progress.