Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented May 13, 2021

based on #936

closes #928, closes #926, closes #952

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

use the new covidcast/meta api to generate a list of sensors that are used in the dashboard.

Moreover, I changed how the regions/indicator picker is shown

image

image

each geographic level (geo_type) has a color that is also used in the line chart
image

Note: blocked by the epidata release

@sgratzl sgratzl added the enhancement New feature or request label May 13, 2021
@sgratzl sgratzl requested a review from krivard May 13, 2021 17:39
@sgratzl sgratzl self-assigned this May 13, 2021
@sgratzl sgratzl changed the title Sgratzl/meta2.0 use new metadata and show all signals in dashboard May 13, 2021
@netlify
Copy link

netlify bot commented May 13, 2021

✔️ Preview link ready!

🔨 Explore the source changes: 5bf336e

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/60c8ebcdd1c9bf00085e1161

😎 Browse the preview: https://deploy-preview-937--cmu-delphi-covidcast.netlify.app

@sgratzl sgratzl removed the blocked The issue is blocked by some other (external) issue described in the comments label Jun 15, 2021
@sgratzl sgratzl marked this pull request as ready for review June 15, 2021 15:17
@sgratzl sgratzl enabled auto-merge June 15, 2021 15:21
@krivard
Copy link
Contributor

krivard commented Jun 15, 2021

There's some commented-out code in here; is that intentional?

label: 'Lab',
component: () => import(/* webpackChunkName: 'mode-lab' */ './lab/Lab.svelte').then((r) => r.default),
},
// {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional we might need that again in the future for experiments

@sgratzl
Copy link
Member Author

sgratzl commented Jun 15, 2021

There's some commented-out code in here; is that intentional?

I just checked again, and removed some old code. Besides that the comments are intentional.

@krivard
Copy link
Contributor

krivard commented Jun 15, 2021

Menu item should read "Dashboard Builder"

@sgratzl
Copy link
Member Author

sgratzl commented Jun 15, 2021

Menu item should read "Dashboard Builder"

see also cmu-delphi/www-main#342

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit d9871f4 into dev Jun 15, 2021
@sgratzl sgratzl deleted the sgratzl/meta2.0 branch June 15, 2021 18:26
@krivard krivard mentioned this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

4 participants