Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented May 12, 2021

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

add support to show the raw cumulative signal version for cases/deaths. part of #928

image

note: the dark green portion is the amount that has been added for this day

@sgratzl sgratzl added the enhancement New feature or request label May 12, 2021
@sgratzl sgratzl self-assigned this May 12, 2021
@sgratzl sgratzl requested a review from krivard May 12, 2021 14:47
@netlify
Copy link

netlify bot commented May 12, 2021

Preview link ready!

Built with commit eb779f7

https://deploy-preview-936--cmu-delphi-covidcast.netlify.app

@netlify
Copy link

netlify bot commented May 12, 2021

Preview link ready!

Built with commit 40d967d

https://deploy-preview-936--cmu-delphi-covidcast.netlify.app

@krivard
Copy link
Contributor

krivard commented May 12, 2021

While "cumulated" is a legit word, it tends to be reserved for far more technical contexts than we need here. Use "cumulative" instead.

I don't understand what "raw: 16.6" means in the caption, since the cumulative data is also raw (unsmoothed). do you mean "incident"? "new" would also work there

@sgratzl
Copy link
Member Author

sgratzl commented May 12, 2021

so far: raw = unsmoothed and cumulative = unsmoothed cumulative. I don't know whether new or incident would be more clear in this case

@sgratzl
Copy link
Member Author

sgratzl commented May 12, 2021

While "cumulated" is a legit word, it tends to be reserved for far more technical contexts than we need here. Use "cumulative" instead.

done

@sgratzl sgratzl changed the title feat: cumulative support for history line charts cumulative support for history line charts May 13, 2021
@sgratzl sgratzl merged commit ed05aaa into dev Jun 15, 2021
@sgratzl sgratzl deleted the sgratzl/cumulated_incidence branch June 15, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants