Repair and log nancodes instead of rejecting files #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve test coverage for this case
dshemetov
force-pushed
the
acquisition_missing_logging
branch
from
19483f6 to
731b071
Compare
* repair and log instead of rejecting files with invalid missing codes * introduce dtype inference code in acquisition to see if further refactors possible * refactor test_csv_uploading for readability
dshemetov
force-pushed
the
acquisition_missing_logging
branch
from
731b071 to
5d9aee7
Compare
…int if you can't.
krivard
reviewed
Oct 5, 2021
Contributor
krivard
left a comment
krivard
left a comment
There was a problem hiding this comment.
Looks good; I modified to pull dtype into a constant and some other small adjustments. take a look and let me know if they're friendly?
4 tasks
Contributor
Author
|
lgtm. the int conversion at the end of floaty_int is probably not needed, since round returns an int type, but it is more clear that way (I didn't expect round to return an int until i checked). |
This was referenced Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #731
Prerequisites:
devbranchdevSummary