Hotfix acquisition: fix dtypes of missing columns #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve test coverage for this case
krivard
reviewed
Oct 4, 2021
4 tasks
krivard
suggested changes
Oct 5, 2021
Contributor
krivard
left a comment
krivard
left a comment
There was a problem hiding this comment.
minor adjustments but otherwise looks good!
Whitespace for readability Co-authored-by: Katie Mazaitis <[email protected]>
Preserve old test cases Co-authored-by: Katie Mazaitis <[email protected]>
Contributor
|
Superseded by #733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728
Prerequisites:
devbranchdevSummary
Missingness code validation was no ready to receive
str(float(missing_code))and therefore caused an error. It should now convert from string to float to int. Added tests to cover this case.