Remove minimum sample size test; include unit tests in dev guide #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Then run the test container: | ||
|
|
||
| ```bash | ||
| docker run --rm --network delphi-net delphi_python \ |
Contributor
There was a problem hiding this comment.
Does the delphi-net network have to be created before this can be run? I don't see that in the backend development docs
Contributor
Author
There was a problem hiding this comment.
It's not in the backend docs, but it is in the frontend ones, and is explicitly called out at the top of this guide: https://github.com/cmu-delphi/delphi-epidata/blob/master/docs/epidata_development.md#epidata-api-development-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deploy of #126 failed because of failing unit tests. Unit tests were not included in the developer guide, so I've added a section describing how to run them. The failing test has been fixed (we no longer want acquisition to fail on a sample size < 5), and all tests pass.