Remove minimum sample size requirement. #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sample size validation.
| # expected a number, but got a string | ||
| return (None, 'sample_size') | ||
| if sample_size is not None and sample_size < CsvImporter.MIN_SAMPLE_SIZE: | ||
| return (None, 'sample_size') |
Contributor
There was a problem hiding this comment.
Probably can also remove the definition of MIN_SAMPLE_SIZE at the top of the file
Contributor
|
Looks fine modulo eliminating dead constants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicators will do their own sample size validation from here on out.
This is necessary for the safegraph indicator, which uses a special definition of sample size (requested by forecasting) that is not based on individual users but on clusters.