Skip to content

Conversation

@krivard
Copy link
Contributor

@krivard krivard commented Nov 17, 2020

Description

As recommended in #522, this PR will merge all deploy-* branches into main. Once it is merged, we will generate prod as a branch from main, and officially begin the new deployment scheme.

Changelog

  • deploy-changehc (3 ahead)
  • deploy-jhu (0 ahead)
  • deploy-usafacts (3 ahead)
  • deploy-google_health (1 ahead)
  • deploy-safegraph (2 ahead)
  • deploy-quidel (13 ahead; conflicts) repaired-deploy-quidel (11 ahead)

@krivard krivard marked this pull request as draft November 17, 2020 15:42
@krivard krivard marked this pull request as ready for review November 17, 2020 16:31
@krivard
Copy link
Contributor Author

krivard commented Nov 17, 2020

@korlaxxalrok to check the ansible vault and verify that both changehc and quidel secrets are included.

@krivard krivard changed the title [DRAFT] Sync all deploy branches into main in prep for generating prod branch Sync all deploy branches into main in prep for generating prod branch Nov 17, 2020
@korlaxxalrok
Copy link
Contributor

@krivard Secrets look good 👌

Copy link
Contributor

@chinandrew chinandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🦜

@krivard krivard merged commit fe80833 into main Nov 17, 2020
@krivard
Copy link
Contributor Author

krivard commented Nov 17, 2020

Merged, created prod branch off of the resulting main, and enacted branch protection rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants