Update main with quidel_covidtest deployment abilities #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to run as quidel_covidtest for now * fixed linter errors * updated pylintrc for automation Co-authored-by: Jingjing Tang <[email protected]>
* We need to run as quidel_covidtest for now * Update params template name to match indicator of quidel_covidtest
krivard
reviewed
Oct 28, 2020
| after_df.loc[added_idx, :]) | ||
|
|
||
|
|
||
| def run_module(archive_type: str, |
Contributor
There was a problem hiding this comment.
Highly suspicious. This change is already in main as 530aba32; what is it doing in this PR?
Contributor
Author
There was a problem hiding this comment.
Mmm, yeah from merging in main. What is your preference for fixing?
Contributor
|
Superseded by #538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
quidel_covidtestindicator.vault.yamlwith necessary credentials for production deployment.