Skip to content

Align transcode.toAnimated with the spec #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Align transcode.toAnimated with the spec #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .code-generation/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ module.exports = {
close: '',
}
},
unsupportedTxParams: ['fl_waveform', 'fl_animated', 'e_theme', 'af_'],
unsupportedSyntaxList: ['.stroke(', '.textFit(', 'Animated.edit', '.RoundCorners(', 'getVideoFrame', '.transcode(']
unsupportedTxParams: ['fl_waveform', 'e_theme', 'af_'],
unsupportedSyntaxList: ['.stroke(', '.textFit(', 'Animated.edit', '.RoundCorners(', 'getVideoFrame']
},
"overwrites": {
qualifiers: {
Expand Down
12 changes: 6 additions & 6 deletions __TESTS__/unit/actions/Transcode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,24 +159,24 @@ describe('Tests for Transformation Action -- Transcode', () => {
expect(url).toBe('https://res.cloudinary.com/demo/video/upload/f_webp,fl_animated,fl_awebp/sample');
});

it('Creates a cloudinaryURL with toAnimated and delay', () => {
it('Creates a cloudinaryURL with toAnimated', () => {
const url = createNewVideo('sample')
.transcode(Transcode
.toAnimated('gif').delay(20))
.toAnimated('gif'))
.setPublicID('sample')
.toURL();

expect(url).toBe('https://res.cloudinary.com/demo/video/upload/dl_20,f_gif,fl_animated/sample');
expect(url).toBe('https://res.cloudinary.com/demo/video/upload/f_gif,fl_animated/sample');
});

it('Creates a cloudinaryURL with toAnimated, delay, sampling', () => {
it('Creates a cloudinaryURL with toAnimated, sampling', () => {
const url = createNewVideo('sample')
.transcode(Transcode
.toAnimated(AnimatedFormat.gif()).delay(20).sampling('4s'))
.toAnimated(AnimatedFormat.gif()).sampling('4s'))
.setPublicID('sample')
.toURL();

expect(url).toBe('https://res.cloudinary.com/demo/video/upload/dl_20,f_gif,fl_animated,vs_4s/sample');
expect(url).toBe('https://res.cloudinary.com/demo/video/upload/f_gif,fl_animated,vs_4s/sample');
});

it('Tests for simple videoCodec', () => {
Expand Down