Skip to content

Align transcode.toAnimated with the spec #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

Align transcode.toAnimated with the spec #528

merged 1 commit into from
May 12, 2022

Conversation

patrick-tolosa
Copy link
Contributor

Pull request for @cloudinary/url-gen

What does this PR solve?

Aligns transcode.toAnimated with our spec

  • Remove Delay (moved to Animated.edit) and fix tests.
  • Remove transcode from unsupported syntax (it's now supported)

Final checklist

  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code.

@patrick-tolosa patrick-tolosa requested a review from strausr May 11, 2022 14:02
@patrick-tolosa patrick-tolosa merged commit 6cca8d9 into master May 12, 2022
@patrick-tolosa patrick-tolosa deleted the feature/align-transcode.toAnimated branch May 12, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strausr strausr strausr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick-tolosa @strausr