Skip to content

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Jun 16, 2025

Description

Certain locales were missing clickable ToS and Privacy Policy links. This PR adds them in.

Fixes USER-2061

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Added clickable links for Terms of Service and Privacy Policy in the sign-up legal consent checkbox for Belarusian, Bulgarian, Czech, Spanish, Italian, Dutch (Belgium and Netherlands), Portuguese (Portugal), and Turkish localizations. This enhancement allows users to directly access legal documents from the consent label in these languages.

@tmilewski tmilewski self-assigned this Jun 16, 2025
@tmilewski tmilewski requested review from aeliox, wobsoriano and a team as code owners June 16, 2025 15:40
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 3:45pm

Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: 2ecaa69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 16, 2025

📝 Walkthrough

Walkthrough

This change updates the legal consent checkbox label in the localization files for nine languages (Belarusian, Bulgarian, Czech, Spanish, Italian, Dutch for Belgium, Dutch for the Netherlands, Portuguese, and Turkish) within the @clerk/localizations package. The static text for the Terms of Service and Privacy Policy is replaced with templated strings that allow dynamic insertion of clickable links. No changes are made to exported entities or logic beyond the modification of these specific localization strings.

Assessment against linked issues

Objective Addressed Explanation
Make the terms of use and privacy policy links clickable on the checkbox label (USER-2061)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Suggested labels

localizations

Suggested reviewers

  • aeliox

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34587ac and 2ecaa69.

📒 Files selected for processing (10)
  • .changeset/tiny-snails-wonder.md (1 hunks)
  • packages/localizations/src/be-BY.ts (1 hunks)
  • packages/localizations/src/bg-BG.ts (1 hunks)
  • packages/localizations/src/cs-CZ.ts (1 hunks)
  • packages/localizations/src/es-ES.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/nl-BE.ts (1 hunks)
  • packages/localizations/src/nl-NL.ts (1 hunks)
  • packages/localizations/src/pt-PT.ts (1 hunks)
  • packages/localizations/src/tr-TR.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Build Packages
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (10)
packages/localizations/src/cs-CZ.ts (1)

661-662: Validate templated legal consent label.
Ensure that the termsOfServiceLink and privacyPolicyLink placeholders render correctly at runtime and that the fallback texts "podmínkami služby" and "politikou ochrany osobních údajů" exactly mirror the single‐policy labels defined above.

packages/localizations/src/nl-BE.ts (1)

663-664: Validate templated legal consent label.
Confirm that the Dutch grammar (“de … en het …”) remains correct when using the link placeholders, and that the fallback texts "Algemene Voorwaarden" and "Privacybeleid" match the respective single‐policy labels.

packages/localizations/src/nl-NL.ts (1)

663-665: Template placeholders added – please sanity-check at runtime

The shift to a templated string looks correct syntactically and grammatically, but because this string now contains inline helpers (link(...)) it’s worth running a quick smoke-test in the UI (or unit/i18n snapshot) to ensure:

  1. The fallback text still renders when either URL is missing.
  2. There are no unescaped braces or broken anchors in the produced HTML.

If you have automated i18n tests, consider adding one that mounts the component with & without termsOfServiceLink / privacyPolicyLink to catch regressions.

packages/localizations/src/it-IT.ts (1)

663-665: Italian consent label converted to template – verify rendered HTML

Implementation mirrors other locales and the article agreement (i … e la …) reads well.
Just confirm at runtime that:

  • Both placeholders resolve to clickable anchors.
  • The surrounding “i / la” articles don’t get duplicated when the helper inserts its own text.

No code issues spotted.

packages/localizations/src/bg-BG.ts (1)

663-664: Correct dynamic template for ToS & Privacy links
The updated label__termsOfServiceAndPrivacyPolicy correctly injects termsOfServiceLink and privacyPolicyLink with fallbacks matching the original Bulgarian text.

packages/localizations/src/be-BY.ts (1)

667-668: Correct dynamic template for ToS & Privacy links
The updated label__termsOfServiceAndPrivacyPolicy correctly injects termsOfServiceLink and privacyPolicyLink with fallbacks matching the original Belarusian text.

packages/localizations/src/pt-PT.ts (1)

661-662: Dynamic linking added correctly

The placeholder syntax matches Clerk’s templating conventions and preserves the original wording/grammar. Looks good to ship.

packages/localizations/src/tr-TR.ts (1)

664-665: Template string LGTM

The new interpolated links follow the expected {{ ... }} pattern and keep the apostrophe-case ending 'nı intact, so the rendered text should read naturally.

packages/localizations/src/es-ES.ts (1)

664-666: Let’s retry with a literal search for || across all locale files:

#!/bin/bash
# Find any literal '||' occurrences in localization sources
rg -F '||' -n packages/localizations/src
.changeset/tiny-snails-wonder.md (1)

1-6: Changelog entry LGTM

The changeset accurately captures the patch-level scope and enumerates the affected locales.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jun 16, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6135

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6135

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6135

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6135

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6135

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6135

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6135

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6135

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6135

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6135

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6135

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6135

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6135

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6135

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6135

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6135

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6135

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6135

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6135

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6135

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6135

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6135

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6135

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6135

commit: 2ecaa69

@tmilewski tmilewski merged commit 656851d into main Jun 16, 2025
40 checks passed
@tmilewski tmilewski deleted the tm/user-2061-clickable-tos branch June 16, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants