Skip to content

Conversation

sdaigo
Copy link
Contributor

@sdaigo sdaigo commented May 8, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Added Japanese language support for legal consent sections, including localized labels for privacy policy and terms of service agreements during sign-up.

Copy link

changeset-bot bot commented May 8, 2025

🦋 Changeset detected

Latest commit: 5def1c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 8, 2025

@sdaigo is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@octoper octoper requested review from aeliox, wobsoriano and a team as code owners June 17, 2025 17:36
Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

📝 Walkthrough

Walkthrough

This change updates the Japanese localization file (ja-JP) in the @clerk/localizations package by adding new entries for legal consent labels in the signUp.legalConsent.checkbox section. The update provides Japanese text templates for agreeing to the privacy policy, terms of service, or both, with embedded placeholders for links. No existing localization content was modified or removed, and there were no changes to exported or public entities.

Possibly related PRs

  • fix(localizations): Add ToS & privacy links #6135: Adds similar templated Terms of Service and privacy policy links for multiple other locales in the same localization package, directly relating to the addition of such templates for Japanese in this PR.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 320937a and 5def1c6.

📒 Files selected for processing (2)
  • .changeset/chatty-fishes-speak.md (1 hunks)
  • packages/localizations/src/ja-JP.ts (1 hunks)
🔇 Additional comments (2)
packages/localizations/src/ja-JP.ts (1)

602-605: Ensure term consistency for “Privacy Policy”.

Throughout the file, “プライバシー(ポリシー)” is used to represent privacy-related links (e.g. footerPageLink__privacy).
For consistency, consider replacing “個人情報保護方針” with the same term:

-label__onlyPrivacyPolicy: '{{privacyPolicyLink || link("個人情報保護方針")}}に同意します',
+label__onlyPrivacyPolicy: '{{privacyPolicyLink || link("プライバシーポリシー")}}に同意します',

-label__termsOfServiceAndPrivacyPolicy:
-  '{{termsOfServiceLink || link("利用規約")}}と{{privacyPolicyLink || link("個人情報保護方針")}}に同意します',
+label__termsOfServiceAndPrivacyPolicy:
+  '{{termsOfServiceLink || link("利用規約")}}と{{privacyPolicyLink || link("プライバシーポリシー")}}に同意します',

This keeps wording uniform and avoids user confusion.
[ suggest_nitpick ]

.changeset/chatty-fishes-speak.md (1)

5-5: Minor wording tweak for clarity.

Consider pluralising “localization” to reflect multiple strings added:

-Add legal consent related localization to `ja-JP`
+Add legal-consent–related localizations to `ja-JP`

[ suggest_nitpick ]


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jacekradko jacekradko merged commit 86f32ab into clerk:main Jun 17, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 22, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants