-
Notifications
You must be signed in to change notification settings - Fork 0
Updates styles for sidebar and cleans up CSS #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
deb9022
Updates styles for sidebar and cleans up CSS
914f638
Cleans up bracket spacing
c032eb4
Fix the sidebar animation while opening & closing groups
ad97f12
Fixes social share sizes, and adds space to left btm sidebar
c9ca1c7
adds space between header and "core"
ebaafac
fixes line-height for nested nested nested nested nested items
64e5eba
Styles aria-pressed to limit spacing under subhead
b253cc6
indents items under recipes, but not sub items
d6c539b
first level sub indents on mobile
30ca15a
Fixes for spacing issues
5aabecb
Rolls back adding class `recipes` in docmap
2c14e21
Reduces sidebar spacing
3fef965
Rolls back spacing between headers and links
a65ef9a
Makes Guides and API links more similar, adds padding to recipes
ad13672
Fixes sub sub sub indents
25f5a4b
Resolves need for !importants in padding
d3628da
Merge branch 'master' into i505
24d741b
Adds padding back in to baseline version number
480c590
Sets space at bottom of sidebar
ba7e4b7
Removes light font-weight for CORE/INF/ECO
bb40f7a
FIxes spacing between items
69c8b1d
Fixes spacing 2, electric boogaloo
6037f78
Smooth transition on collapsable close
8824b2a
Removes indent from top line lists
feff81f
Scroll to the top when new pages are loaded
7b693c6
adds line to sidebar
cbf9203
Update the docMap
8c585d7
Fix an issue with searching in Chrome
03533cb
Merge branch 'master' into i505
a2880de
Make the sidebar a flexible width & fix scrolling issues
8b131b2
Fixes +/- icon to be more inline with text
725e3ce
Fixes nested nested nested ul top spacing
091afe5
adds `-ms-grid` support for IE11
a42487b
adds variable to where hearder height is used
ec2eb74
escapes header variable in LESS calc
f336699
Removes the recipes-specific class for top leve styling
bfff807
adds more space between top-level pages on mobile
29ab553
Minor style fixes
5570d63
Merge branch 'master' into i505
45ff279
Skip a test that was specific to the Recipes page
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| body { | ||
| height: 100%; | ||
| overflow: hidden; | ||
| overflow: auto; | ||
| margin: 0px; | ||
| } | ||
| html { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,44 @@ | ||
| #everything { | ||
| .flex; | ||
| -webkit-flex-flow: row wrap; | ||
| justify-content: flex-start; | ||
| align-items: stretch; | ||
| flex-wrap: nowrap; | ||
| box-sizing: border-box; | ||
| height: calc(~"100% - 53px");// 53px header | ||
| -webkit-overflow-scrolling: touch; | ||
| padding-bottom: 0; | ||
| transition: padding-bottom @transition-speed ease; | ||
| display:-ms-grid; | ||
| display: grid; | ||
| -ms-grid-columns: 300px 1fr; | ||
| grid-template-columns: max-content 1fr; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realized |
||
| grid-template-areas: "header header" "left-nav content"; | ||
| } | ||
| #left { | ||
| -ms-grid-row: 2; | ||
| -ms-grid-column: 1; | ||
| -ms-grid-column-span: 1; | ||
| grid-area: left-nav; | ||
| height: calc(~"100vh - " @brand-height);// 53px header | ||
| overflow-y: scroll; | ||
| position: fixed; | ||
| scroll-behavior: smooth; | ||
| top: @brand-height; | ||
| width: @sidebar-width; | ||
| min-width: 0; | ||
| transition: min-width @transition-speed ease; | ||
| border-right: 3px solid #F4F4F4; | ||
| @media screen and (min-width: @breakpoint){ | ||
| flex-shrink: 0; | ||
| padding: 0px; | ||
| position: relative; | ||
| .sticky; | ||
| margin: @brand-height 0 0; | ||
| width: auto; | ||
| } | ||
| } | ||
| #right { | ||
| height: 100%; | ||
| min-height: 100%; | ||
| max-height: 100%; | ||
| background: white; | ||
| display: flex; | ||
| -ms-grid-column: 2; | ||
| grid-area: content; | ||
| overflow-x: hidden; | ||
| // z-index: 90; | ||
| padding-top: @brand-height; | ||
| position: relative; | ||
| left: 0; | ||
| .transition-left; | ||
| flex-grow: 1; | ||
| @media screen and (min-width: @breakpoint){ | ||
| display: flex; | ||
| flex-grow: 1; | ||
| } | ||
| } | ||
| .column { | ||
| height: 100%; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this look like when it’s cut off?