Updates styles for sidebar and cleans up CSS #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
reviewed
May 3, 2019
docMap.json
Outdated
| "name": "guides/recipes", | ||
| "title": "recipes", | ||
| "type": "page", | ||
| "type": "page recipes", |
Member
There was a problem hiding this comment.
I don’t think this file should’ve changed.
Merged
Also add smooth-scroll to the left sidebar.
chasenlehara
reviewed
May 6, 2019
static/sidebar.less
Outdated
| border-radius: 5px; | ||
| box-shadow: 0 0 5px @link-color; | ||
| a.page.recipes + ul { | ||
| padding-left: 5px; |
Member
There was a problem hiding this comment.
I removed the Recipes page and updated the docMap on this branch, so I think this can probably be removed now.
This switches from flexbox to CSS grid for the layout of the header, sidebar, and content. This still allows the left sidebar and content to scroll independently while also fixing some scrolling issues. Fixes #507
| transition: padding-bottom @transition-speed ease; | ||
| display:-ms-grid; | ||
| display: grid; | ||
| -ms-grid-columns: 300px 1fr; |
Member
There was a problem hiding this comment.
What does this look like when it’s cut off?
| display:-ms-grid; | ||
| display: grid; | ||
| -ms-grid-columns: 300px 1fr; | ||
| grid-template-columns: max-content 1fr; |
Member
There was a problem hiding this comment.
I just realized max-content isn’t supported by Edge. Maybe we should also add a rule for fit-content(50%) or something else that would work? https://developer.mozilla.org/en-US/docs/Web/CSS/fit-content
static/layout.less
Outdated
| position: relative; | ||
| .sticky; | ||
| margin: 53px 0 0; | ||
| height: calc(~"100vh - 53px");// 53px header |
Member
There was a problem hiding this comment.
We should use a variable wherever we have 53px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505