Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Oct 27, 2025

Refs #333

I haven't actually tried running this, so no idea if it actually works 😛

@ADmad ADmad force-pushed the method-templates branch 2 times, most recently from bc26b50 to 0d108dc Compare October 27, 2025 07:12
@ADmad
Copy link
Member Author

ADmad commented Oct 27, 2025

I haven't actually tried running this, so no idea if it actually works

The docker build passes, so that's a good sign.

@ADmad ADmad requested a review from Copilot October 27, 2025 09:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying template parameter information for methods in the documentation. The changes extract @template tags from docblocks and render them in the function detail template with their bounds and default values.

  • Extracts @template tags from docblocks and stores them in the tags array
  • Adds a new "Templates" section in the function detail page to display template parameters
  • Displays template name, bound, and default value for each template parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Reflection/DocBlock.php Parses and stores @template tags from docblocks
templates/pages/parts/function-detail.twig Renders template parameters in a dedicated section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ADmad ADmad requested a review from othercorey October 27, 2025 09:06
@ADmad ADmad merged commit 89d5eca into 2.x Oct 27, 2025
2 checks passed
@ADmad ADmad deleted the method-templates branch October 27, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants