Handle workflowCompleted error in java client #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demirkayaender
force-pushed
the
tchannel_already_completed_error
branch
from
a5b2966 to
38b3526
Compare
demirkayaender
changed the title
demirkayaender
commented
Apr 28, 2021
| } else { | ||
| metricsScope.gauge(MetricsType.ACTIVITY_ACTIVE_THREAD_COUNT).update(Thread.activeCount()); | ||
| } | ||
| if (isLocalActivity) { |
There was a problem hiding this comment.
This is autoformatting from the IDE, please ignore.
demirkayaender
force-pushed
the
tchannel_already_completed_error
branch
from
38b3526 to
ff391ba
Compare
yux0
approved these changes
Apr 28, 2021
demirkayaender
force-pushed
the
tchannel_already_completed_error
branch
from
ff391ba to
73476c5
Compare
yycptt
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
With this PR (#606) we have been handling WorkflowExecutionAlreadyCompletedError in couple places except for the tchannel. This diff adds tchannel support for this error.
Why?
How did you test it?
I need some help on how we test java-client changes E2E, sending the PR as the context; will update here once I have the testing strategy
Potential risks
Release notes
Documentation Changes