Handle workflowCompleted error in workflow service

demirkayaender · demirkayaender · commit a5b2966601cc · 2021-04-26T10:05:42.000-07:00
diff --git a/src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java b/src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java
@@ -591,9 +591,6 @@ private GetWorkflowExecutionHistoryResponse getWorkflowExecutionHistory(
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
-      if (result.isSetEntityNotExistError()) {
-        throw result.getEntityNotExistError();
-      }
       throw new TException("GetWorkflowExecutionHistory failed with unknown error:" + result);
     } finally {
       if (response != null) {
@@ -704,6 +701,9 @@ private RespondDecisionTaskCompletedResponse respondDecisionTaskCompleted(
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetClientVersionNotSupportedError()) {
         throw result.getClientVersionNotSupportedError();
       }
@@ -742,6 +742,9 @@ private void respondDecisionTaskFailed(RespondDecisionTaskFailedRequest failedRe
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -751,9 +754,6 @@ private void respondDecisionTaskFailed(RespondDecisionTaskFailedRequest failedRe
       if (result.isSetLimitExceededError()) {
         throw result.getLimitExceededError();
       }
-      if (result.isSetEntityNotExistError()) {
-        throw result.getEntityNotExistError();
-      }
       if (result.isSetClientVersionNotSupportedError()) {
         throw result.getClientVersionNotSupportedError();
       }
@@ -840,6 +840,9 @@ private RecordActivityTaskHeartbeatResponse recordActivityTaskHeartbeat(
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -890,6 +893,9 @@ private RecordActivityTaskHeartbeatResponse recordActivityTaskHeartbeatByID(
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -937,6 +943,9 @@ private void respondActivityTaskCompleted(RespondActivityTaskCompletedRequest co
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -985,6 +994,9 @@ private void respondActivityTaskCompletedByID(
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1032,6 +1044,9 @@ private void respondActivityTaskFailed(RespondActivityTaskFailedRequest failRequ
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1080,6 +1095,9 @@ private void respondActivityTaskFailedByID(RespondActivityTaskFailedByIDRequest
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1127,6 +1145,9 @@ private void respondActivityTaskCanceled(RespondActivityTaskCanceledRequest canc
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1175,6 +1196,9 @@ private void respondActivityTaskCanceledByID(
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1224,6 +1248,9 @@ private void requestCancelWorkflowExecution(RequestCancelWorkflowExecutionReques
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetCancellationAlreadyRequestedError()) {
         throw result.getCancellationAlreadyRequestedError();
       }
@@ -1273,6 +1300,9 @@ private void signalWorkflowExecution(SignalWorkflowExecutionRequest signalReques
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1421,6 +1451,9 @@ private void terminateWorkflowExecution(TerminateWorkflowExecutionRequest termin
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -1847,6 +1880,9 @@ private ResetStickyTaskListResponse resetStickyTaskList(ResetStickyTaskListReque
       if (result.isSetEntityNotExistError()) {
         throw result.getEntityNotExistError();
       }
+      if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+        throw result.getWorkflowExecutionAlreadyCompletedError();
+      }
       if (result.isSetServiceBusyError()) {
         throw result.getServiceBusyError();
       }
@@ -2332,6 +2368,10 @@ private void signalWorkflowExecution(
                   resultHandler.onError(result.getEntityNotExistError());
                   return;
                 }
+                if (result.isSetWorkflowExecutionAlreadyCompletedError()) {
+                  resultHandler.onError(result.getWorkflowExecutionAlreadyCompletedError());
+                  return;
+                }
                 if (result.isSetServiceBusyError()) {
                   resultHandler.onError(result.getServiceBusyError());
                   return;

Original file line number	Diff line number	Diff line change
`@@ -591,9 +591,6 @@ private GetWorkflowExecutionHistoryResponse getWorkflowExecutionHistory(`
`591`	`591`	`if (result.isSetServiceBusyError()) {`
`592`	`592`	`throw result.getServiceBusyError();`
`593`	`593`	`}`
`594`		`- if (result.isSetEntityNotExistError()) {`
`595`		`- throw result.getEntityNotExistError();`
`596`		`- }`
`597`	`594`	`throw new TException("GetWorkflowExecutionHistory failed with unknown error:" + result);`
`598`	`595`	`} finally {`
`599`	`596`	`if (response != null) {`
`@@ -704,6 +701,9 @@ private RespondDecisionTaskCompletedResponse respondDecisionTaskCompleted(`
`704`	`701`	`if (result.isSetEntityNotExistError()) {`
`705`	`702`	`throw result.getEntityNotExistError();`
`706`	`703`	`}`
	`704`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`705`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`706`	`+ }`
`707`	`707`	`if (result.isSetClientVersionNotSupportedError()) {`
`708`	`708`	`throw result.getClientVersionNotSupportedError();`
`709`	`709`	`}`
`@@ -742,6 +742,9 @@ private void respondDecisionTaskFailed(RespondDecisionTaskFailedRequest failedRe`
`742`	`742`	`if (result.isSetEntityNotExistError()) {`
`743`	`743`	`throw result.getEntityNotExistError();`
`744`	`744`	`}`
	`745`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`746`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`747`	`+ }`
`745`	`748`	`if (result.isSetServiceBusyError()) {`
`746`	`749`	`throw result.getServiceBusyError();`
`747`	`750`	`}`
`@@ -751,9 +754,6 @@ private void respondDecisionTaskFailed(RespondDecisionTaskFailedRequest failedRe`
`751`	`754`	`if (result.isSetLimitExceededError()) {`
`752`	`755`	`throw result.getLimitExceededError();`
`753`	`756`	`}`
`754`		`- if (result.isSetEntityNotExistError()) {`
`755`		`- throw result.getEntityNotExistError();`
`756`		`- }`
`757`	`757`	`if (result.isSetClientVersionNotSupportedError()) {`
`758`	`758`	`throw result.getClientVersionNotSupportedError();`
`759`	`759`	`}`
`@@ -840,6 +840,9 @@ private RecordActivityTaskHeartbeatResponse recordActivityTaskHeartbeat(`
`840`	`840`	`if (result.isSetEntityNotExistError()) {`
`841`	`841`	`throw result.getEntityNotExistError();`
`842`	`842`	`}`
	`843`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`844`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`845`	`+ }`
`843`	`846`	`if (result.isSetServiceBusyError()) {`
`844`	`847`	`throw result.getServiceBusyError();`
`845`	`848`	`}`
`@@ -890,6 +893,9 @@ private RecordActivityTaskHeartbeatResponse recordActivityTaskHeartbeatByID(`
`890`	`893`	`if (result.isSetEntityNotExistError()) {`
`891`	`894`	`throw result.getEntityNotExistError();`
`892`	`895`	`}`
	`896`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`897`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`898`	`+ }`
`893`	`899`	`if (result.isSetServiceBusyError()) {`
`894`	`900`	`throw result.getServiceBusyError();`
`895`	`901`	`}`
`@@ -937,6 +943,9 @@ private void respondActivityTaskCompleted(RespondActivityTaskCompletedRequest co`
`937`	`943`	`if (result.isSetEntityNotExistError()) {`
`938`	`944`	`throw result.getEntityNotExistError();`
`939`	`945`	`}`
	`946`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`947`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`948`	`+ }`
`940`	`949`	`if (result.isSetServiceBusyError()) {`
`941`	`950`	`throw result.getServiceBusyError();`
`942`	`951`	`}`
`@@ -985,6 +994,9 @@ private void respondActivityTaskCompletedByID(`
`985`	`994`	`if (result.isSetEntityNotExistError()) {`
`986`	`995`	`throw result.getEntityNotExistError();`
`987`	`996`	`}`
	`997`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`998`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`999`	`+ }`
`988`	`1000`	`if (result.isSetServiceBusyError()) {`
`989`	`1001`	`throw result.getServiceBusyError();`
`990`	`1002`	`}`
`@@ -1032,6 +1044,9 @@ private void respondActivityTaskFailed(RespondActivityTaskFailedRequest failRequ`
`1032`	`1044`	`if (result.isSetEntityNotExistError()) {`
`1033`	`1045`	`throw result.getEntityNotExistError();`
`1034`	`1046`	`}`
	`1047`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1048`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1049`	`+ }`
`1035`	`1050`	`if (result.isSetServiceBusyError()) {`
`1036`	`1051`	`throw result.getServiceBusyError();`
`1037`	`1052`	`}`
`@@ -1080,6 +1095,9 @@ private void respondActivityTaskFailedByID(RespondActivityTaskFailedByIDRequest`
`1080`	`1095`	`if (result.isSetEntityNotExistError()) {`
`1081`	`1096`	`throw result.getEntityNotExistError();`
`1082`	`1097`	`}`
	`1098`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1099`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1100`	`+ }`
`1083`	`1101`	`if (result.isSetServiceBusyError()) {`
`1084`	`1102`	`throw result.getServiceBusyError();`
`1085`	`1103`	`}`
`@@ -1127,6 +1145,9 @@ private void respondActivityTaskCanceled(RespondActivityTaskCanceledRequest canc`
`1127`	`1145`	`if (result.isSetEntityNotExistError()) {`
`1128`	`1146`	`throw result.getEntityNotExistError();`
`1129`	`1147`	`}`
	`1148`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1149`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1150`	`+ }`
`1130`	`1151`	`if (result.isSetServiceBusyError()) {`
`1131`	`1152`	`throw result.getServiceBusyError();`
`1132`	`1153`	`}`
`@@ -1175,6 +1196,9 @@ private void respondActivityTaskCanceledByID(`
`1175`	`1196`	`if (result.isSetEntityNotExistError()) {`
`1176`	`1197`	`throw result.getEntityNotExistError();`
`1177`	`1198`	`}`
	`1199`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1200`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1201`	`+ }`
`1178`	`1202`	`if (result.isSetServiceBusyError()) {`
`1179`	`1203`	`throw result.getServiceBusyError();`
`1180`	`1204`	`}`
`@@ -1224,6 +1248,9 @@ private void requestCancelWorkflowExecution(RequestCancelWorkflowExecutionReques`
`1224`	`1248`	`if (result.isSetEntityNotExistError()) {`
`1225`	`1249`	`throw result.getEntityNotExistError();`
`1226`	`1250`	`}`
	`1251`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1252`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1253`	`+ }`
`1227`	`1254`	`if (result.isSetCancellationAlreadyRequestedError()) {`
`1228`	`1255`	`throw result.getCancellationAlreadyRequestedError();`
`1229`	`1256`	`}`
`@@ -1273,6 +1300,9 @@ private void signalWorkflowExecution(SignalWorkflowExecutionRequest signalReques`
`1273`	`1300`	`if (result.isSetEntityNotExistError()) {`
`1274`	`1301`	`throw result.getEntityNotExistError();`
`1275`	`1302`	`}`
	`1303`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1304`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1305`	`+ }`
`1276`	`1306`	`if (result.isSetServiceBusyError()) {`
`1277`	`1307`	`throw result.getServiceBusyError();`
`1278`	`1308`	`}`
`@@ -1421,6 +1451,9 @@ private void terminateWorkflowExecution(TerminateWorkflowExecutionRequest termin`
`1421`	`1451`	`if (result.isSetEntityNotExistError()) {`
`1422`	`1452`	`throw result.getEntityNotExistError();`
`1423`	`1453`	`}`
	`1454`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1455`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1456`	`+ }`
`1424`	`1457`	`if (result.isSetServiceBusyError()) {`
`1425`	`1458`	`throw result.getServiceBusyError();`
`1426`	`1459`	`}`
`@@ -1847,6 +1880,9 @@ private ResetStickyTaskListResponse resetStickyTaskList(ResetStickyTaskListReque`
`1847`	`1880`	`if (result.isSetEntityNotExistError()) {`
`1848`	`1881`	`throw result.getEntityNotExistError();`
`1849`	`1882`	`}`
	`1883`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`1884`	`+ throw result.getWorkflowExecutionAlreadyCompletedError();`
	`1885`	`+ }`
`1850`	`1886`	`if (result.isSetServiceBusyError()) {`
`1851`	`1887`	`throw result.getServiceBusyError();`
`1852`	`1888`	`}`
`@@ -2332,6 +2368,10 @@ private void signalWorkflowExecution(`
`2332`	`2368`	`resultHandler.onError(result.getEntityNotExistError());`
`2333`	`2369`	`return;`
`2334`	`2370`	`}`
	`2371`	`+ if (result.isSetWorkflowExecutionAlreadyCompletedError()) {`
	`2372`	`+ resultHandler.onError(result.getWorkflowExecutionAlreadyCompletedError());`
	`2373`	`+ return;`
	`2374`	`+ }`
`2335`	`2375`	`if (result.isSetServiceBusyError()) {`
`2336`	`2376`	`resultHandler.onError(result.getServiceBusyError());`
`2337`	`2377`	`return;`