Skip to content

Bug 1446236 - BugmailFilter: Divorce from Review extension #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bug 1446236 - BugmailFilter: Divorce from Review extension #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6907159
BugmailFilter: Divorce from Review extension
CyberShadow Mar 31, 2018
84ff09d
BugmailFilter: Calculate FILTER_RELATIONSHIPS lazily
CyberShadow Apr 3, 2018
d838804
BugmailFilter: Update name of has_extension function
CyberShadow Jun 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions extensions/BugmailFilter/Extension.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,10 @@ sub _should_drop {
$rel_map[8] = !$rel_map[8];
$rel_map[9] = ($relationship & $bit_watching or $relationship & $bit_compwatch);
$rel_map[10] = !$rel_map[9];
$rel_map[11] = $bug->is_mentor($user);
$rel_map[12] = !$rel_map[11];
if (Bugzilla->has_extension('Review')) {
$rel_map[11] = $bug->is_mentor($user);
$rel_map[12] = !$rel_map[11];
}
foreach my $bool (@rel_map) {
$bool = $bool ? 1 : 0;
}
Expand Down
36 changes: 21 additions & 15 deletions extensions/BugmailFilter/lib/Constants.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,21 +67,27 @@ use constant IGNORE_FIELDS => qw(
use constant FIELD_DESCRIPTION_OVERRIDE => {bug_id => 'Bug Created',};

# relationship / int mappings
# _should_drop() also needs updating when this const is changed
# _should_drop() also needs updating when this is changed

use constant FILTER_RELATIONSHIPS => [
{name => 'Assignee', value => 1,},
{name => 'Not Assignee', value => 2,},
{name => 'Reporter', value => 3,},
{name => 'Not Reporter', value => 4,},
{name => 'QA Contact', value => 5,},
{name => 'Not QA Contact', value => 6,},
{name => "CC'ed", value => 7,},
{name => "Not CC'ed", value => 8,},
{name => 'Watching', value => 9,},
{name => 'Not Watching', value => 10,},
{name => 'Mentoring', value => 11,},
{name => 'Not Mentoring', value => 12,},
];
sub FILTER_RELATIONSHIPS() {
state $relations;
return \@$relations if $relations;
my $index = 1;
push @$relations, { name => 'Assignee', value => $index++ };
push @$relations, { name => 'Not Assignee', value => $index++ };
push @$relations, { name => 'Reporter', value => $index++ };
push @$relations, { name => 'Not Reporter', value => $index++ };
push @$relations, { name => 'QA Contact', value => $index++ };
push @$relations, { name => 'Not QA Contact', value => $index++ };
push @$relations, { name => "CC'ed", value => $index++ };
push @$relations, { name => "Not CC'ed", value => $index++ };
push @$relations, { name => 'Watching', value => $index++ };
push @$relations, { name => 'Not Watching', value => $index++ };
if (Bugzilla->has_extension('Review')) {
push @$relations, { name => 'Mentoring', value => $index++ };
push @$relations, { name => 'Not Mentoring', value => $index++ };
}
return \@$relations;
}

1;