Bug 1446236 - BugmailFilter: Divorce from Review extension #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberShadow
commented
Mar 31, 2018
| @@ -356,8 +356,10 @@ sub _should_drop { | |||
| or $relationship & $bit_compwatch | |||
| ); | |||
| $rel_map[10] = !$rel_map[9]; | |||
| $rel_map[11] = $bug->is_mentor($user); | |||
| $rel_map[12] = !$rel_map[11]; | |||
| if (Bugzilla->have_extension('Review')) { | |||
| return \@relations; | ||
| } | ||
|
|
||
| use constant FILTER_RELATIONSHIPS => _gen_relations(); |
CyberShadow
changed the title
CyberShadow
force-pushed
the
bugmailfilter-wo-review
branch
from
65c0b7d to
ca93f18
Compare
@dylanwh Done, but... it seems that this and the other PRs were based on the |
Don't include or process Mentor fields if the Review extension isn't loaded.
Calculating it eagerly is problematic as it would have to be done at extension initialization, and we can't meaningfully query whether other extensions are loaded during extension initialization. Do it lazily and cache the result instead.
CyberShadow
force-pushed
the
bugmailfilter-wo-review
branch
from
a4ccb33 to
d838804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't include or process Mentor fields if the Review extension isn't loaded.