Skip to content

Show error message when build is in running state #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Show error message when build is in running state #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d266c9c
Show erro rmessage when build is in running state
suryart Jan 11, 2021
493147a
Fixing the logic of capturing the error
suryart Jan 12, 2021
6cc70f5
Adding unit tests for reporter changes
suryart Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bin/helpers/reporterHTML.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,17 @@ let reportGenerator = (bsConfig, buildId, args, cb) => {
message = Constants.userMessages.API_DEPRECATED;
logger.info(message);
}
} else if (resp.statusCode === 422) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases for this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

messageType = Constants.messageTypes.ERROR;
errorCode = 'api_failed_build_generate_report';
try {
response = JSON.parse(body);
message = response.message;
} catch (error) {
logger.error(`Error generating the report: ${error}`);
response = {message: message};
}
logger.error(response.message);
} else if (resp.statusCode != 200) {
messageType = Constants.messageTypes.ERROR;
errorCode = 'api_failed_build_generate_report';
Expand Down
31 changes: 31 additions & 0 deletions test/unit/bin/helpers/reporterHTML.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,37 @@ describe("reportHTML", () => {
});

context("non 200 response", () => {
it("422 status, build available but running, cannot generate report", () => {
let build = { message: 'The report cannot be generated as the build is running' };
let body = JSON.stringify(build);
let requestStub = sandbox.stub(request, "get").yields(null, { statusCode: 422 }, body);
let message = build.message;
let messageType = Constants.messageTypes.ERROR;
let errorCode = 'api_failed_build_generate_report';

const reporterHTML = proxyquire('../../../../bin/helpers/reporterHTML', {
'./utils': {
validateBstackJson: validateBstackJsonStub,
setDefaultAuthHash: setDefaultAuthHashStub,
setUsername: setUsernameStub,
setAccessKey: setAccessKeyStub,
getUserAgent: getUserAgentStub,
setUsageReportingFlag: setUsageReportingFlagStub,
setCypressConfigFilename: setCypressConfigFilenameStub,
sendUsageReport: sendUsageReportStub,
setDefaults: setDefaultsStub,
getErrorCodeFromErr: getErrorCodeFromErrStub
},
request: {get: requestStub}
});

reporterHTML.reportGenerator(bsConfig, buildId, args);

sinon.assert.calledOnce(requestStub);
sinon.assert.calledOnce(getUserAgentStub);
sinon.assert.calledOnceWithExactly(sendUsageReportStub, bsConfig, args, message, messageType, errorCode);
});

it("400 status, build available, cannot generate report", () => {
let build = { buildId: buildId, message: 'success', rows: [] };
let body = JSON.stringify(build);
Expand Down