Skip to content

Conversation

suryart
Copy link
Collaborator

@suryart suryart commented Jan 11, 2021

In case when generate build command is fired when the build is running, this change will not show an error message instead of generating an incorrect build report.

@@ -135,6 +135,15 @@ let reportGenerator = (bsConfig, buildId, args, cb) => {
message = Constants.userMessages.API_DEPRECATED;
logger.info(message);
}
} else if (resp.statusCode === 422) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases for this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@suryart suryart merged commit a1016ad into master Feb 1, 2021
@suryart suryart deleted the running-build-report-generate-status branch February 1, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants