Make Values.TangentVector == VectorValues #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hmm, this build failure is very mysterious because it doesn't happen on Linux and also this PR doesn't seem to touch anything related to it. I'll investigate. |
marcrasi
force-pushed
the
marcrasi/values_tangent_vector_rebased
branch
from
8ec2226 to
7c7c188
Compare
Collaborator
Author
|
I figured out the compile error. I have included a workaround, and I also made a proper fix that should appear in toolchains eventually: swiftlang/swift#31723 |
Collaborator
|
@marcrasi This PR is great :) Since the |
Collaborator
Author
Oh yes, done. |
ProfFan
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is #49, rebased to feature/nlfg_with_manifold. I'm pasting the same description below.)
This sets
Values.TangentVectortoVectorValues, which allows a few nice improvements to the APIs:Valueusing aVectorValues, now all you need isvals.move(along: vectorval)instead of needing to loop over all the components and cast them.JacobianFactorinitializer that linearizes any error function, which simplifies the implementation oflinearize.Other API changes:
vals[key, as: Pose2.self]instead ofvals[key].baseAs(Pose2.self). This is necessary so thatValuesknows what type you are accessing and therefore knows how to convert its tangent vector to aVectorsuitable for inclusion inVectorValues.vals.insert(key, value)instead ofvals.insert(key, AnyDifferentiable(value). (It still gets stored as a type-erasedAnyDifferentiablethough).