[AutoDiff] fix array subscript lookup when there are multiple #31723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci please test |
dan-zheng
approved these changes
May 12, 2020
Contributor
dan-zheng
left a comment
dan-zheng
left a comment
There was a problem hiding this comment.
Nice! That looks interesting to debug 🙂
rxwei
approved these changes
May 12, 2020
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jun 3, 2020
…ang#31723) Fix `PullbackEmitter::getArrayAdjointElementBuffer` to always lookup `Array.TangentVector.subscript` from the stdlib. Resolves compiler crash when user code also defines `Array.TangentVector.subscript`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The differentiation transform sometimes tries to call the wrong subscript when there are multiple subscripts.
This concretely causes problems when you
import TensorFlowbecause this subscript has different conformances in its generic signature than the correct subscript, so you get an assertion failure while trying to construct a substitution map for it: