Upgrade bitcoin to v0.31 #79
Conversation
|
Excuse the noise, this is another go at #78 because I saw #76. This is #60 with pinning in CI. I previously handed off to @getong because he did #74 but that seems to be stalling. Lets see if I can get this past CI. I copied the pinning done by @notmandatory's PR and tweaked it a bit after upgrading the |
Upgrade: - bitcoin to v0.31.0 - miniscript to v11.0.0 Requires currently unreleased: - rust-hwi: master branch - rust-esplora-clinet: bitcoindevkit/rust-esplora-client#79
Upgrade: - bitcoin to v0.31.0 - miniscript to v11.0.0 Requires currently unreleased: - rust-hwi: master branch - rust-esplora-clinet: bitcoindevkit/rust-esplora-client#79
| run: | | ||
| cargo update -p zstd-sys --precise "2.0.8+zstd.1.5.5" | ||
| cargo update -p zstd-sys --precise "2.0.6+zstd.1.5.2" | ||
| cargo update -p zstd --precise 0.11.2+zstd.1.5.2 |
There was a problem hiding this comment.
Why do we now require to pin zstd individually? I think the +zstd.1.5.5 already should pin it to a particular version? Moreover, any reason why we reduce the pinned zstd-sys version from 2.0.8 to 2.0.6?
There was a problem hiding this comment.
I didn't think too hard about it to be honest, I find pinning to be a total waist of brain space so I just wildly try versions until something works.
There was a problem hiding this comment.
Oh, I remember. I brought zstd-sys back to be in line with the new zstd, but like you say we may not need both. (Referring to the +1.5.2)
There was a problem hiding this comment.
Yeah, I think we don't need to pin both and if pinning zstd-sys to 2.0.8+zstd.1.5.5 is sufficient to meet the MSRV, I'd always prefer to pin to the higher version.
There was a problem hiding this comment.
I agree with @tnull, can we change this back to zstd-sys and zstd 1.5.5? You can verify on crates.io that 1.5.5 is the latest version with MSRV under 1.63: https://crates.io/crates/zstd-sys/versions
There was a problem hiding this comment.
Changed as requested, lets let CI prove if it works for us
| cargo update -p time --precise "0.3.20" | ||
| cargo update -p jobserver --precise "0.1.26" | ||
| cargo update -p home --precise 0.5.5 | ||
| cargo update -p jobserver --precise 0.1.26 |
There was a problem hiding this comment.
This is pinned above already, no need to duplicate here.
There was a problem hiding this comment.
Ouch, I thought I remove that locally. Will re-spin, thanks.
tcharding
force-pushed
the
02-07-upgrade-bitcoin-0.31
branch
from
e2cfe89 to
e41b360
Compare
|
I left, |
|
Thanks for the review @tnull! |
tcharding
force-pushed
the
02-07-upgrade-bitcoin-0.31
branch
from
e41b360 to
581cfb0
Compare
|
Done, thanks. |
Pull Request Test Coverage Report for Build 7896060347Details
💛 - Coveralls |
Upgrade dependencies to use the latest `rust-bitcoin v0.31`. While we are at it, bump the crate version ready for release. (Includes pinning dependencies for MSRV build in CI.)
tcharding
force-pushed
the
02-07-upgrade-bitcoin-0.31
branch
from
581cfb0 to
c046047
Compare
|
You guys were right about the pins, thanks for pushing me. |
c0460471236db834aafa0a4d618d90fc9b1d25ef Upgrade bitcoin (Tobin C. Harding)
Pull request description:
Upgrade dependencies to use the latest `rust-bitcoin v0.31`.
While we are at it, bump the crate version ready for release.
(Includes pinning dependencies for MSRV build in CI.)
ACKs for top commit:
notmandatory:
utACK c0460471236db834aafa0a4d618d90fc9b1d25ef
Tree-SHA512: 547902dc645b6b983eebde9eafe290cfec714824549873ef1456264d619c32f52509fdde7e1c5bc7dbc7cb3b47bd7104fba83327f3206c22debf954e0e96872a
5 participants
Upgrade dependencies to use the latest
rust-bitcoin v0.31.While we are at it, bump the crate version ready for release.
(Includes pinning dependencies for MSRV build in CI.)