Skip to content

Bump electrsd to 0.26 + bitcoind_25_0 and fix msrv errors #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2024
Merged

Bump electrsd to 0.26 + bitcoind_25_0 and fix msrv errors #76

merged 3 commits into from
Feb 7, 2024

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Feb 3, 2024 •
edited
Loading

This PR bumps electrsd to 0.26 and replaces temporary dependency on bitcoin-internals with hex-conservative as done in #75. Fixed CI MSRV issues with dev dependencies blocking #75 and #74.

@notmandatory notmandatory added the ci Continuous Integration issues label Feb 3, 2024
@notmandatory notmandatory added this to the Release 0.7.0 milestone Feb 3, 2024
@notmandatory notmandatory self-assigned this Feb 3, 2024
@notmandatory notmandatory force-pushed the bump_electrsd branch 2 times, most recently from c20ed68 to 06f6bca Compare February 3, 2024 23:22
@notmandatory notmandatory mentioned this pull request Feb 3, 2024
Merged
@notmandatory notmandatory marked this pull request as draft February 4, 2024 01:31
@notmandatory
Copy link
Member Author

notmandatory commented Feb 4, 2024

For some reason with the default feature set the tests aren't completing so I moved this to draft until I get that figured out.

storopoli
storopoli approved these changes Feb 4, 2024
View reviewed changes
Copy link

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 06f6bca

@notmandatory notmandatory marked this pull request as ready for review February 5, 2024 00:15
@coveralls
Copy link

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7777789071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 78.934%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 1 97.49%
src/api.rs 10 14.49%
Totals Coverage Status
Change from base Build 7383678843: -1.1%
Covered Lines: 918
Relevant Lines: 1163
💛 - Coveralls

@notmandatory
Copy link
Member Author

notmandatory commented Feb 5, 2024

To get the default feature tests to run without locking up I had to limit test threads to 1.

@storopoli
Copy link

storopoli commented Feb 5, 2024

To get the default feature tests to run without locking up I had to limit test threads to 1.

Have you tried 2?
I've managed to get away with 2 in GH Action runners in the past.

tnull
tnull reviewed Feb 5, 2024
View reviewed changes
@notmandatory
Copy link
Member Author

notmandatory commented Feb 5, 2024

To get the default feature tests to run without locking up I had to limit test threads to 1.

Have you tried 2? I've managed to get away with 2 in GH Action runners in the past.

Two would probably work, but it runs fast enough with 1 so I don't see a need to push it.

oleonardolima
oleonardolima reviewed Feb 6, 2024
View reviewed changes
evanlinjin
evanlinjin approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac2fd86

@tcharding tcharding mentioned this pull request Feb 7, 2024
Merged
tcharding
tcharding approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac2fd86

@notmandatory notmandatory merged commit 7faab65 into bitcoindevkit:master Feb 7, 2024
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
@chrono-raven6i90
Merge bitcoindevkit/rust-esplora-client#76: Bump electrsd to 0.26 + b…
273971a 
…itcoind_25_0 and fix msrv errors

ac2fd862ef5b457fc7e158f3f19ef64c77589136 ci: limit test threads to 1 (Steve Myers)
19bdeb17abfc4f9fa1e514b333f488c81be430f8 replace temporary dependency on bitcoin-internals with hex-conservative (Steve Myers)
c99118e3437eae2db218f961f46e773c2778abe9 bump electrsd to 0.26 + bitcoind_25_0 and fix msrv errors (Steve Myers)

Pull request description:

  This PR bumps electrsd to 0.26 and replaces temporary dependency on `bitcoin-internals` with `hex-conservative` as done in #75. Fixed CI MSRV issues with dev dependencies blocking #75 and #74.

ACKs for top commit:
  evanlinjin:
    ACK ac2fd862ef5b457fc7e158f3f19ef64c77589136
  tcharding:
    ACK ac2fd862ef5b457fc7e158f3f19ef64c77589136

Tree-SHA512: 37d825aae78d1ca89806870455b97a48e5a69bbdd78adadb16f506fb4df0fe98dc3a262b8fb74b68f5c44031e76c8fa0b5304c8592bf332356a0215843a52c33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

+3 more reviewers

@tnull tnull tnull approved these changes

@tcharding tcharding tcharding approved these changes

@storopoli storopoli storopoli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@notmandatory notmandatory

Labels

ci Continuous Integration issues

Projects

None yet

Milestone

Release 0.7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@notmandatory @coveralls @storopoli @tnull @tcharding @evanlinjin @oleonardolima