Skip to content

Personal refactor #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Personal refactor #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4570f71
refactor(props): change wrap-tag type
bimalghartimagar Jul 21, 2022
a8408d9
refactor(render): pass props to wrapping tag
bimalghartimagar Jul 21, 2022
1d2303f
feat(range): add method to get range
bimalghartimagar Jul 21, 2022
d069bd3
build: run prod build for new changes
bimalghartimagar Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@
"default": 'div'
},
wrapTag: {
type: String,
type: [Object, Function],
"default": 'div'
},
wrapClass: {
Expand Down Expand Up @@ -699,9 +699,6 @@
}
});

/**
* virtual list default component
*/
var EVENT_TYPE = {
ITEM: 'item_resize',
SLOT: 'slot_resize'
Expand Down Expand Up @@ -745,9 +742,20 @@
this.$on(EVENT_TYPE.SLOT, this.onSlotResized);
}
},
// set back offset when awake from keep-alive
activated: function activated() {
// set back offset when awake from keep-alive
this.scrollToOffset(this.virtual.offset);

if (this.pageMode) {
document.addEventListener('scroll', this.onScroll, {
passive: false
});
}
},
deactivated: function deactivated() {
if (this.pageMode) {
document.removeEventListener('scroll', this.onScroll);
}
},
mounted: function mounted() {
// set position
Expand All @@ -773,6 +781,10 @@
}
},
methods: {
// get range of shown items
getRange: function getRange() {
return this.range;
},
// get item size by id
getSize: function getSize(id) {
return this.virtual.sizes.get(id);
Expand Down Expand Up @@ -1033,6 +1045,7 @@
attrs: {
role: 'group'
},
props: _objectSpread2({}, this.extraProps),
style: wrapperStyle
}, this.getRenderSlots(h)), // footer slot
footer ? h(Slot, {
Expand Down
Loading