Personal refactor #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated wrap-tag props type to accept component so a vue component can be passed as wrapper * Gist: vue-smooth-dnd uses Container to wrap list of items that are draggable
* Pass extraProps to container tag so, custom values can be passed to custom container
* Add method to get current range of shown items, so the dragged item can be indexed based on the start range index and dragged index
|
Merging. |
bimalghartimagar
added a commit
that referenced
this pull request
Jan 21, 2024
* refactor(props): change wrap-tag type * Updated wrap-tag props type to accept component so a vue component can be passed as wrapper * Gist: vue-smooth-dnd uses Container to wrap list of items that are draggable * refactor(render): pass props to wrapping tag * Pass extraProps to container tag so, custom values can be passed to custom container * feat(range): add method to get range * Add method to get current range of shown items, so the dragged item can be indexed based on the start range index and dragged index * build: run prod build for new changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of this PR? (check at least one)
Other information: