Fix fine grained deps symlinks #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
reviewed
Nov 16, 2018
| stat = fs.statSync(fullPath); | ||
| } catch (e) { | ||
| if (fs.lstatSync(fullPath).isSymbolicLink()) { | ||
| // filter out broken symbolic links... these cause fs.statSync(fullPath) |
Contributor
There was a problem hiding this comment.
What happens if the symlink is valid? I assume it won't even cause an error then right?
Collaborator
Author
There was a problem hiding this comment.
Yes. Then everything is fine. On Windows you get broken symlinks for .bin which is why it was filtered out and on OSX/Linux there are cases when symlinks are broken under test such as ecstatic/test/public/containsSymlink/more-problematic.
alexeagle
approved these changes
Nov 16, 2018
This was referenced Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.