-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: remove windows runfile workaround #14173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove windows runfile workaround #14173
Conversation
jelbourn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Just a note that rules_nodejs 0.16.1 won't work with material but the latest commit will (symlink issue fixed by bazel-contrib/rules_nodejs#422). This was due to the You can either update this PR to that commit or Alex should tag 0.16.2 shortly. With the rules_nodejs update, the update to yarn 1.10+ is possible as well which supports the |
1ba79e3 to
f85f68c
Compare
* Since bazel-contrib/rules_nodejs@1f97eb6 landed, we can safely remove the workaround by updating the NodeJS and TypeScript Bazel rules. * Also we are creating our own `getFileContent` testing method because it's not guaranteed that the internal testing utilities from `@schematics/angular` always stay the same. Additionally this works around an issue where `test` folders are excluded in the Bazel managed deps by default.
f85f68c to
9c4056b
Compare
|
Rebased. This is ready now. |
* Since bazel-contrib/rules_nodejs@1f97eb6 landed, we can safely remove the workaround by updating the NodeJS and TypeScript Bazel rules. * Also we are creating our own `getFileContent` testing method because it's not guaranteed that the internal testing utilities from `@schematics/angular` always stay the same. Additionally this works around an issue where `test` folders are excluded in the Bazel managed deps by default.
* Since bazel-contrib/rules_nodejs@1f97eb6 landed, we can safely remove the workaround by updating the NodeJS and TypeScript Bazel rules. * Also we are creating our own `getFileContent` testing method because it's not guaranteed that the internal testing utilities from `@schematics/angular` always stay the same. Additionally this works around an issue where `test` folders are excluded in the Bazel managed deps by default.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
getFileContenttesting method because it's not guaranteed that the internal testing utilities from@schematics/angularalways stay the same. Additionally this works around an issue wheretestfolders are excluded in the Bazel managed deps by default.Blocked on angular/angular#27138 being merged.