Fixing sqs fifo message order consuming #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandomoraes
requested review from
eddumelendez and
maciejwalkowiak
as code owners
| } | ||
| catch (MessagingException messagingException) { | ||
| applyDeletionPolicyOnError(receiptHandle); | ||
| if (!applyDeletionPolicyOnError(receiptHandle)) { |
There was a problem hiding this comment.
I was wondering about this also. Perhaps it would be a little clearer like this ? (Just a proposition)
Suggested change
| if (!applyDeletionPolicyOnError(receiptHandle)) { | |
| if (shouldDeleteMessageOnError(receiptHandle)) { | |
| deleteMessage(receiptHandle); | |
| } else { | |
| break; | |
| } |
There was a problem hiding this comment.
Yeh, I agree with you, it would be clearer
|
Thanks @fernandomoraes for contribution and apologies for late review. Looks legit 👌 |
maciejwalkowiak
approved these changes
Feb 7, 2022
9 tasks
maciejwalkowiak
added
component: sqs
MatejNedic
approved these changes
Feb 8, 2022
|
Lets consider #124 (comment) before merging. |
|
Ok, it's already included. |
|
thanks @fernandomoraes and @sebastiandusza! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
SQS FIFO messages aren't being consumed in a correct order. The order miss occurs when an error is throwable by the consumer handler.
💡 Motivation and Context
When message of a certain message group could not be consumed, newer messages from the same message group should wait until this message be consumed with success or the message dropped by the sqs.
💚 How did you test it?
📝 Checklist
🔮 Next steps