Stop processing messages from FIFO queue when exception is thrown #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception is thrown
sebastiandusza
requested review from
eddumelendez and
maciejwalkowiak
as code owners
sebastiandusza
commented
Sep 3, 2021
| } | ||
| catch (MessagingException messagingException) { | ||
| applyDeletionPolicyOnError(receiptHandle); | ||
| break; |
There was a problem hiding this comment.
I'm wondering if this break should be executed only when this.deletionPolicy == ON_SUCCESS ?
There was a problem hiding this comment.
Hello @sebastiandusza
I missed your pull request, and opened another with the same implementation.
Take a look what I implemented about this question.
There was a problem hiding this comment.
Hi @fernandomoraes, cool :-)
I posted a small comment. Please consider if it makes sense.
|
Thanks @sebastiandusza and apologies for late review. I am closing this as #192 is already in place and it has a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
I think there is a bug in
SimpleMessageListenerContainer.MessageGroupExecutorclass.When multiple messages from the same message group are recieved and exception is thrown while
processing one them the others should not be processed. I think this is importand because
the order should be maintained even in case of an error.
💡 Motivation and Context
I think it solves this issue
#124
💚 How did you test it?
I integrated it with my app that is using SQS FIFO queue and checked if order is maintained in case of an exception.
Also I prepared a unit test.
📝 Checklist
🔮 Next steps