Skip to content

Conversation

@winstonaws
Copy link
Contributor

@winstonaws winstonaws commented Apr 20, 2018

This will reduce transient failures for our tests. Usually endpoint creation happens in ~10 minutes, but occasionally it can go up to ~30 minutes arbitrarily.

If the sagemaker endpoint creation is fast but our container fails to start up, we will still fail fast.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@winstonaws winstonaws requested a review from yangaws April 20, 2018 00:33
Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files          36       36           
  Lines        2438     2438           
=======================================
  Hits         2206     2206           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9362bba...3076a39. Read the comment docs.

@winstonaws winstonaws merged commit f1e0781 into aws:master Apr 20, 2018
@winstonaws winstonaws deleted the endpoint_timeouts branch April 20, 2018 02:19
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Changed: Kernel for Breast Cancer Prediction.ipynb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants