Skip to content

Conversation

@ngoyal16
Copy link
Contributor

Description of changes:

CFN Template added so that end users can easily create the queue and event subscriptions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merge from upstream
CFN Templates added for the queue and event subscription
@ngoyal16 ngoyal16 requested a review from a team as a code owner March 16, 2022 13:45
@ngoyal16
Copy link
Contributor Author

/rerun

@AustinSiu AustinSiu self-requested a review March 17, 2022 15:58
Copy link
Contributor

@AustinSiu AustinSiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this @ngoyal16!
Just a few comments, please take a look.

@AustinSiu
Copy link
Contributor

The failing tests are not related to your changes, so don't be concerned about that. We'll get a PR out this afternoon to fix it. Similar change can be seen here: aws/amazon-ec2-metadata-mock#168

@ngoyal16 ngoyal16 requested a review from AustinSiu March 18, 2022 18:14
@AustinSiu
Copy link
Contributor

@ngoyal16 we merged a fix for the failing tests, thanks for your patience. Can you please rebase?

@ngoyal16
Copy link
Contributor Author

@ngoyal16 we merged a fix for the failing tests, thanks for your patience. Can you please rebase?

@AustinSiu done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants