publish images to ecr public repo #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
👍
may I ask for a review from you here, Brandon? aws-controllers-k8s/community#584
It's a similar story in ACK land.
Makefile
Outdated
| @docker login -u ${DOCKER_USERNAME} -p="${DOCKERHUB_TOKEN}" | ||
| ${MAKEFILE_PATH}/scripts/push-docker-images -p ${SUPPORTED_PLATFORMS_WINDOWS} -r ${IMG} -v ${VERSION} -m | ||
| ${MAKEFILE_PATH}/scripts/retag-docker-images -p ${SUPPORTED_PLATFORMS_LINUX} -v ${VERSION} -o ${IMG} -n ${ECR_REPO} | ||
| @docker login --username AWS -p="$(shell aws ecr-public get-login-password --region us-east-1)" ${ECR_REGISTRY} |
There was a problem hiding this comment.
Note that this will only work with extremely up-to-date aws CLI :)
haugenj
approved these changes
Dec 16, 2020
2 tasks
haugenj
pushed a commit
to haugenj/aws-node-termination-handler
that referenced
this pull request
Feb 19, 2021
* publish images to ecr public repo * add ecr-public-login script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/eks-charts#356
#295
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.