update release and publish scripts for ECR #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
approved these changes
Dec 17, 2020
docs/contents/dev-docs/release.md
Outdated
|
|
||
| ```bash | ||
| for SERVICE in s3 sns; | ||
| do ./scripts/publish-controller-image.sh -s $SERVICE -r public.ecr.aws/aws-controllers-k8s/controller; |
There was a problem hiding this comment.
The push script was recently changed to use environment variables and one argument. It should be called like:
export DOCKER_REPOSITORY=public.ecr.aws/aws-controllers-k8s/controller
for SERVICE in s3 sns;
do ./scripts/publish-controller-image.sh $SERVICE;
doneThere was a problem hiding this comment.
Fixed, thanks for the heads up!
jaypipes
force-pushed
the
helm
branch
2 times, most recently
from
b089282 to
d4722f8
Compare
Modifies our release docs and publish scripts to use our new ECR public registry (public.ecr.aws/aws-controllers-k8s) for storing Docker images for the controllers and Helm charts. Note that the public alias "public.ecr.aws/aws-controllers-k8s" is still not resolving from the generated alias of "public.ecr.aws/m5q3e4b2" but that should be done shortly by the ECR team. Issue aws-controllers-k8s#366
a-hilaly
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies our release docs and publish scripts to use our new ECR public
registry (public.ecr.aws/aws-controllers-k8s) for storing Docker images
for the controllers and Helm charts.
Note that the public alias "public.ecr.aws/aws-controllers-k8s" is still
not resolving from the generated alias of "public.ecr.aws/m5q3e4b2" but
that should be done shortly by the ECR team.
Issue #366
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.