Wire-up rust-openssl into GitHub CI (for the time being) #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
rust-openssl-ci
branch
3 times, most recently
from
455fbd8 to
239f0a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
+ Coverage 79.04% 79.05% +0.01%
==========================================
Files 614 614
Lines 106946 107003 +57
Branches 15144 15156 +12
==========================================
+ Hits 84531 84591 +60
+ Misses 21762 21758 -4
- Partials 653 654 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
force-pushed
the
rust-openssl-ci
branch
5 times, most recently
from
86648fa to
dfcc09b
Compare
skmcgrail
force-pushed
the
rust-openssl-ci
branch
from
dfcc09b to
fd998bc
Compare
skmcgrail
changed the title
justsmth
approved these changes
Mar 26, 2025
samuel40791765
approved these changes
Mar 27, 2025
Merged
skmcgrail
added a commit
that referenced
this pull request
Mar 28, 2025
## What's Changed * Revert "Allow constructed strings in BER parsing (#2015)" by @samuel40791765 in #2278 * Add the rehash utility to the openssl CLI tool by @smittals2 in #2258 * Documentation on service indicator by @justsmth in #2281 * Update patches in Ruby CI by @samuel40791765 in #2233 * Reject DSA trailing garbage in EVP layer, add test cases by @skmcgrail in #2289 * Add support for verifying PKCS7 signed attributes by @samuel40791765 in #2264 * Add support for more SSL BIO functions by @samuel40791765 in #2273 * Wire-up rust-openssl into GitHub CI (for the time being) by @skmcgrail in #2291 * Adding detection of out-of-bound pre-bound memory read to AES-XTS tests. by @nebeid in #2286 * AES: Add function pointer trampoline to avoid delocator issue by @hanno-becker in #2294 * Bump mysql CI to 9.2.0 by @samuel40791765 in #2161 * Cherrypick hardening DSA param checks from BoringSSL by @smittals2 in #2293 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds validation that AWS-LC will build with rust-openssl when using the bindgen feature or bindgen-cli if pointed at an AWS-LC installation directory. We will add coverage on the aws-lc-rs side specifically for handling coverage of the crate specific feature flag that toggles on
aws-lc-sys.Call-outs:
Not putting this into CodeBuild right now as it would require building new docker images with Rust, and the current process is influx. Will wait for the new deployment process to be completed so we can guarantee more frequently updated rust compiler releases without having to automate that with each invocation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.