Skip to content

Conversation

@samuel40791765
Copy link
Contributor

Description of changes:

We've finalized our changes upstream and we should update our patches to previous branches to align. This also helps minimize churn when applying these patches internally.

Call-outs:

N/A

Testing:

CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (8a9ebcf) to head (46d561c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
- Coverage   79.04%   79.03%   -0.02%     
==========================================
  Files         612      614       +2     
  Lines      106630   106934     +304     
  Branches    15098    15144      +46     
==========================================
+ Hits        84291    84515     +224     
- Misses      21685    21764      +79     
- Partials      654      655       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuel40791765 samuel40791765 force-pushed the ruby-patch-update branch 4 times, most recently from b6d7c06 to 6257571 Compare March 7, 2025 01:26
@samuel40791765 samuel40791765 marked this pull request as ready for review March 7, 2025 01:26
@samuel40791765 samuel40791765 requested a review from a team as a code owner March 7, 2025 01:26
@samuel40791765 samuel40791765 force-pushed the ruby-patch-update branch 2 times, most recently from ef4accc to a6f7084 Compare March 7, 2025 21:36
@justsmth
Copy link
Contributor

The ruby_release_fips_{0,1}_integration_x86_64 tests are failing:

make[1]: Leaving directory '/codebuild/output/src74814705/src/github.com/aws/aws-lc/RUBY_BUILD_ROOT/ruby-src/ruby_3_4'
/codebuild/output/src74814705/src/github.com/aws/aws-lc/RUBY_BUILD_ROOT/ruby-src/ruby_3_4/tool/lib/test/unit.rb:1147:in 'Test::Unit::GlobOption#complement_test_name': file not found: test/drb/*ssl*.rb (ArgumentError)

smittals2
smittals2 previously approved these changes Mar 19, 2025
@samuel40791765 samuel40791765 merged commit 85b5a95 into aws:main Mar 21, 2025
102 of 108 checks passed
@samuel40791765 samuel40791765 deleted the ruby-patch-update branch March 21, 2025 19:43
@skmcgrail skmcgrail mentioned this pull request Mar 28, 2025
skmcgrail added a commit that referenced this pull request Mar 28, 2025
## What's Changed
* Revert "Allow constructed strings in BER parsing (#2015)" by
@samuel40791765 in #2278
* Add the rehash utility to the openssl CLI tool by @smittals2 in
#2258
* Documentation on service indicator by @justsmth in
#2281
* Update patches in Ruby CI by @samuel40791765 in
#2233
* Reject DSA trailing garbage in EVP layer, add test cases by @skmcgrail
in #2289
* Add support for verifying PKCS7 signed attributes by @samuel40791765
in #2264
* Add support for more SSL BIO functions by @samuel40791765 in
#2273
* Wire-up rust-openssl into GitHub CI (for the time being) by @skmcgrail
in #2291
* Adding detection of out-of-bound pre-bound memory read to AES-XTS
tests. by @nebeid in #2286
* AES: Add function pointer trampoline to avoid delocator issue by
@hanno-becker in #2294
* Bump mysql CI to 9.2.0 by @samuel40791765 in
#2161
* Cherrypick hardening DSA param checks from BoringSSL by @smittals2 in
#2293

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants