Skip to content

Silence ecs execute-command session manager plugin check #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Silence ecs execute-command session manager plugin check #6653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion awscli/customizations/ecs/executecommand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import logging
import json
import errno
import os

from subprocess import check_call
from awscli.compat import ignore_user_entered_signals
Expand Down Expand Up @@ -83,7 +84,7 @@ def invoke(self, service_name, operation_name, parameters, parsed_globals):
# before calling execute-command to ensure that
# session-manager-plugin is installed
# before execute-command-command is made
check_call(["session-manager-plugin"])
check_call(["session-manager-plugin"], stdout=open(os.devnull, 'wb'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about simplifying this to just use subprocess.DEVNULL (and importing DEVNULL from subprocess up at the top)?

Suggested change
check_call(["session-manager-plugin"], stdout=open(os.devnull, 'wb'))
check_call(["session-manager-plugin"], stdout=DEVNULL)

client = self._session.create_client(
service_name, region_name=parsed_globals.region,
endpoint_url=parsed_globals.endpoint_url,
Expand Down