Silence ecs execute-command session manager plugin check #6653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stretch96
changed the title
justindho
reviewed
Jun 1, 2022
There was a problem hiding this comment.
@Stretch96 Thanks for the contribution! This seems reasonable to me. Just had a small comment.
| # session-manager-plugin is installed | ||
| # before execute-command-command is made | ||
| check_call(["session-manager-plugin"]) | ||
| check_call(["session-manager-plugin"], stdout=open(os.devnull, 'wb')) |
There was a problem hiding this comment.
What do you think about simplifying this to just use subprocess.DEVNULL (and importing DEVNULL from subprocess up at the top)?
Suggested change
| check_call(["session-manager-plugin"], stdout=open(os.devnull, 'wb')) | |
| check_call(["session-manager-plugin"], stdout=DEVNULL) |
justindho
added
feature-request
|
Checking in - it looks like we haven't heard back in a couple of years here. I'm going to close this PR as inactive, if still interested in these changes please create a new issue/PR for continuing the discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
aws ecs execute-command, it unnecessarily outputs:This is because within the
ExecuteCommandCallerClass,check_call(["session-manager-plugin"])is usedcheck_callin this case is only used to ensure that the command existsChanging
stddoutto devnull, will still exit if the command errors (eg. ifsession-manager-plugindoesn't exist)