-
Notifications
You must be signed in to change notification settings - Fork 249
Ensure delete-word tries to stop at the end of the line #581
Conversation
|
@dsandstrom can you please clarify what you mean by |
|
I guess I was mistaken. I was thinking that if you entered |
|
hi guys, is this fix production ready? If so, can this fix be included in the next release? Issue #550 hits me 10+ times per day. |
|
@chrisvdb No, it's more of a proof of concept. I'm waiting to hear from @maxbrunsfeld or @kevinsawicki for some feedback. |
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this method ever called with a second argument? I only see the one call on line 215.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just copied cursor's regex function: https://github.com/atom/atom/blob/37cb6b6d9e2be35af51b4e7e812b833efc24ce11/src/cursor.coffee#L642. My original intent was to merge the changes back to Atom.
|
As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions! |
Fixes #550.
$. I'd rather have an option built into the Cursor class instead of adding it to this package. I can submit that PR if that is a better approach.allowEOLoption from vim-state.coffee, but couldn't figure out how to do that. Right now, the custom word regex is set for all delete operators.dwalso deletes the preceeding space, which this PR doesn't fix.