Delete word (dw) should not delete line break

[dsandstrom]

If I have a line of code and I try to delete the last word, dw joins the lower line to the current line. I would expect more of the behavior that de provides. It deletes the word, but doesn't join the lower line.

test test
nope

becomes

test nope

I would expect

test
nope

[maxbrunsfeld]

Yeah, I think I introduced this regression during the push to get multi-cursors working everywhere. The w motion behaves differently in visual and operator-pending modes, so we would need to differentiate between modes in MoveToNextWord::moveCursor. I'd love to merge a PR fixing this.

[dsandstrom]

@maxbrunsfeld Just to confirm, visual and command mode w should wrap. However, operator-pending mode w should not wrap (eg. dw and d1000w).

[maxbrunsfeld]

@dsandstrom right. Thanks for clarifying.

[dsandstrom]

If there is only one word left, dw should delete to the end of the line and not join the next line. However, I think dw should wrap if you are at the end of the line. That is probably what you wanted, but I just want to be clear.

I wasn't able to spend a lot of time on this over the weekend, but I did get something working. For my solution, I had to use a modified Cursor::wordRegExp. I need to add $ to the normal one. Should I make a PR to add a optional end of line to Atom's cursor or use a custom @wordRegExp that this package uses? I don't think you can add two RegExp's together (I might be able to split the Atom's wordRegExp and re-join, but probably not worth it).

[huanzhang]

+1

[ssfrr]

👍

[bronson]

I disagree that dw should wrap if you're at the end of the line. Vim doesn't. It just deletes the last character on the line.

I absolutely agree that this needs to be fixed. It affects me many times during the day.

[dsandstrom]

@bronson I agree now, we should match vim as much as possible. That is what I was referring to in #581, but you said it more succinctly.

In vim, I noticed that dw also deletes the preceding space, which this PR doesn't fix.

[brandall10]

Any movement on this? Coming from VIM to Atom recently, this is probably my #1 gripe. I've trained myself to do a d$ for the last word as a workaround, but still muscle memory gets the best of me at times.

[jacekkopecky]

Hmm, this one has fallen through the cracks. @dsandstrom do you have any spare cycles to update #581? If you don't, I can clone that PR and finish it.

[dsandstrom]

I should have some time this weekend.

[brandall10]

@dsandstrom

You are my hero. Much appreciated.